Enables the tablefunc extension for the steampipe database. Closes #1154
#1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidaguerre
requested changes
Nov 30, 2021
db/db_local/start_services.go
Outdated
| @@ -180,6 +181,13 @@ func startDB(port int, listen StartListenType, invoker constants.Invoker) (start | |||
| return ServiceFailedToStart, err | |||
| } | |||
|
|
|||
| // ensure the foreign server exists in the database | |||
db/db_local/start_services.go
Outdated
| @@ -438,6 +446,30 @@ func setupLogCollector(postgresCmd *exec.Cmd) (chan string, func(), error) { | |||
| return publishChannel, closeFunction, nil | |||
| } | |||
|
|
|||
| // ensures that the necessary extensions are installed on the database | |||
| func ensureNecessaryExtns(databaseName string) error { | |||
There was a problem hiding this comment.
now ask yourself - what am I going to say about this function name?
binaek
force-pushed
the
tablefunc_extension_1154
branch
from
274edde
to
b652e9d
Compare
binaek
force-pushed
the
tablefunc_extension_1154
branch
from
b652e9d
to
7fa20f1
Compare
kaidaguerre
reviewed
Dec 7, 2021
db/db_local/start_services.go
Outdated
| for _, extn := range extensions { | ||
| _, err = rootClient.Exec(fmt.Sprintf("create extension if not exists %s", db_common.PgEscapeName(extn))) | ||
| if err != nil { | ||
| errorLock.Lock() |
There was a problem hiding this comment.
why the lock? this is syncronous
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pskrbasu can you add a couple of tests for this?
Here's the docs to the extension:
https://www.postgresql.org/docs/12/tablefunc.html