Fix issue where service is not shutdown if interrupted while interactive prompt is initialising. Closes #1004 #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binaek
force-pushed
the
interactive_init_ctrld_1004
branch
from
2444a87
to
6d833b2
Compare
kaidaguerre
requested changes
Jan 5, 2022
interactive/interactive_client.go
Outdated
| client.Close() | ||
| } | ||
|
|
||
| // init data cleanup |
There was a problem hiding this comment.
need a better comment here - this is important - this cleanup shuts the service
// cleanup the init data to ensure any services we started are stopped
| @@ -7,6 +7,7 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/turbot/steampipe/db/db_common" | |||
| "github.com/turbot/steampipe/workspace" | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.