Fix issue where schema extraction is broken for remote services. Closes #1497 #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidaguerre
requested changes
Mar 2, 2022
| schemas := connectionSchemaMap.UniqueSchemas() | ||
| query := c.buildSchemasQuery(schemas) | ||
|
|
||
| acquireSessionResult := c.AcquireSession(ctx) |
There was a problem hiding this comment.
why do we need to acquire session here, but the base implementation just calls
connection, err := c.dbClient.Conn(ctx)
There was a problem hiding this comment.
This is because dbClient is not a public property in the DbClient struct
db/db_local/local_db_client.go
Outdated
| } | ||
| } | ||
|
|
||
| func (c *LocalDbClient) buildSchemasQuery(hintSchemas []string) string { |
There was a problem hiding this comment.
what are hintSchemas?
just call it schemas
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
function comment to explain why this is different from the base version
kaidaguerre
requested changes
Mar 2, 2022
db/db_local/local_db_client.go
Outdated
| @@ -194,6 +196,8 @@ func (c *LocalDbClient) GetSchemaFromDB(ctx context.Context) (*schema.Metadata, | |||
| return metadata, nil | |||
| } | |||
|
|
|||
| // update schemaMetadata to add in all other schemas which have the same schemas as those we have loaded | |||
| // NOTE: this mutates schemaMetadata | |||
There was a problem hiding this comment.
feel free to remove the extra spaces from my suggested comment
db/db_local/local_db_client.go
Outdated
| } | ||
| } | ||
|
|
||
| func (c *LocalDbClient) buildSchemasQuery(exemplarSchemas []string) string { |
There was a problem hiding this comment.
just schemas will be fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.