Adds support for installing all referenced plugins when no arguments are given to 'plugin install'. Closes #3451 #3842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidaguerre
requested changes
Sep 13, 2023
cmd/plugin.go
Outdated
| return | ||
|
|
||
| if len(steampipeconfig.GlobalConfig.Plugins) == 0 { | ||
| error_helpers.ShowError(ctx, sperr.New("No connections/plugins configured")) |
There was a problem hiding this comment.
"No connections or plugins configured"
cmd/plugin.go
Outdated
| } | ||
|
|
||
| // get the list of plugins to install | ||
| for _, plugin := range steampipeconfig.GlobalConfig.Plugins { |
There was a problem hiding this comment.
can we use a lookup instead of StringSliceContains
pkg/ociinstaller/imageref.go
Outdated
| return getCondensedImageRef(r.DisplayImageRef()) | ||
| } | ||
|
|
||
| func getCondensedImageRef(imagePath string) string { |
There was a problem hiding this comment.
shouldn't imagePath be imageRef?
Can we have a unit test suite please
binaek
force-pushed
the
3451-steampipe-plugin-install-without-arguments-should-discover-required-plugins-and-install
branch
from
1f978e0
to
97cc404
Compare
kaidaguerre
deleted the
3451-steampipe-plugin-install-without-arguments-should-discover-required-plugins-and-install
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.