Support Stable Spaces #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2021
turt2live
approved these changes
May 11, 2021
johannescpk
reviewed
May 31, 2021
| invite: opts.invites || [], | ||
| power_level_content_override: { | ||
| ban: 100, | ||
| events_default: 50, |
There was a problem hiding this comment.
Currently looking into spaces support in the matrix-rust-sdk and wondered: MSC1772 states
Space-rooms should be created with a power level for
events_defaultof 100
Is 50 used here for backwards-compatibility or was there another reason?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
Requires #115
This change breaks support for unstable spaces by removing the existing functions / classes and renaming/graduating them to the stable areas:
getSpace/createSpaceare now part ofMatrixClientMSC1772Spaceis now calledSpaceThis goes without saying, but care must be taken to review that this PR matches the spec outlined in https://github.com/matrix-org/matrix-doc/blob/master/proposals/1772-groups-as-rooms.md
This PR might be best reviewed file by file, as they are somewhat independent.