Add note about port of X-Forwarded-Host to nginx.conf example #1190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tusd will use
X-Forwarded-Host
as the host if-behind-proxy
is enabled. However, the example Nginx config doesn't put the port number intoX-Forwarded-Host
, but only the address. This makes the URL returned by tusd to be on port 80/443 instead of what Nginx is actually listening on.Changing
proxy_set_header X-Forwarded-Host $host
toproxy_set_header X-Forwarded-Host $host:$server_port
can fix this problem. But this leads to the occurrence of:80
/:443
in the returned URL even the client doesn't put:80
/:443
in theHost
header, which can be a little weird. So I just add a comment about this.Related issue: #136