Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing orientation during video playback causes stretched image #3508

Closed
1 task done
NeatNit opened this issue Apr 3, 2023 · 3 comments
Closed
1 task done

Changing orientation during video playback causes stretched image #3508

NeatNit opened this issue Apr 3, 2023 · 3 comments
Milestone

Comments

@NeatNit
Copy link

NeatNit commented Apr 3, 2023

When tapping a video to watch it, the orientation remains in portrait. Then, to switch to landscape for a bigger picture, I rotate the device. At this point, the video gets stretched horizontally to fill the entire screen, showing the wrong aspect ratio.

Tap video:
VideoCapture_20230403-234638

Rotate to landscape:
VideoCapture_20230403-234644

The same can happen in reverse - switching from landscape to portrait mid-playback will stretch the video vertically.

Browse in landscape, tap video:
VideoCapture_20230403-234653

Rotate to portrait:
VideoCapture_20230403-234655


  • Tusky Version: 21.0

  • Android Version: 13

  • Android Device: Samsung Galaxy S22+

  • Mastodon instance (if applicable): Videos I tried watching came from birdsite mirror profile: https://bird.makeup/users/kann_news

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.

@NeatNit
Copy link
Author

NeatNit commented Apr 3, 2023

You can watch the demo that those screen-grabs were taken from here (youtube), but it can be disorienting (ha) with the way orientation changes were encoded into the recording. I wish I had another camera to record externally, it would have made it clearer.

@Reonu
Copy link

Reonu commented Jul 8, 2023

Same on Pixel 6 with Android 13

nikclayton added a commit that referenced this issue Aug 10, 2023
Behaviour is consistent with previous player except that:

- Swapping apps while a video is playing, and then returning to Tusky,
will keep the seek position in the video instead of returning to the
start
- The controls/media description can be shown by tapping anywhere, not
just on the video itself
- The media description is on-screen for the same duration as the player
controls (5 seconds here, 3 seconds in the previous code)
- The user has options to control the playback speed
- Rotating the device does not squash/stretch the video
- Show the media preview when playing audio-only files

Fixes #3329,
#3141,
#3126,
#2753,
#3508,
#3291

---------

Co-authored-by: mcc <andi.m.mcclure@gmail.com>
@charlag
Copy link
Collaborator

charlag commented Nov 18, 2023

fixed by #3857

@charlag charlag closed this as completed Nov 18, 2023
@charlag charlag modified the milestones: Tusky 12, Tusky 24 Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants