Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade autodispose #1490

Merged
merged 3 commits into from
Sep 22, 2019
Merged

upgrade autodispose #1490

merged 3 commits into from
Sep 22, 2019

Conversation

connyduck
Copy link
Collaborator

They renamed the extension function from autoDisposable to autoDispose

@charlag
Copy link
Collaborator

charlag commented Sep 21, 2019

Should we disable hiding to save on allocations? uber/AutoDispose#376
I think we don't need to protect things from ourselves

Their new withScope() is 🔥
Feels like some Ruby magic except there's no magic.

@connyduck
Copy link
Collaborator Author

So I should set AutoDisposePlugins#setHideProxies() to false somewhere in our Application class and it will improve performance?

@charlag
Copy link
Collaborator

charlag commented Sep 21, 2019

That's how I understand it. The difference is probably marginal but it may add up with many streams

@connyduck
Copy link
Collaborator Author

nice, thx for the tip

@connyduck connyduck merged commit 546cb4b into master Sep 22, 2019
@connyduck connyduck deleted the upgrade_autodispose branch September 28, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlag charlag Awaiting requested review from charlag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connyduck @charlag