Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArrayIndexOutOfBoundsException #3808

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Fix ArrayIndexOutOfBoundsException #3808

merged 1 commit into from
Jul 6, 2023

Conversation

nikclayton
Copy link
Contributor

Fixes #3807

charlag
charlag reviewed Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@charlag charlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know why/how this happens?

@nikclayton
Copy link
Contributor Author

do we know why/how this happens?

Documentation for bindingAdapterPosition says: "Note that if you've called RecyclerView.Adapter.notifyDataSetChanged(), until the next layout pass, the return value of this method will be NO_POSITION."

connyduck
connyduck approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@connyduck connyduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build failed because of some network issue, I restarted it

@nikclayton nikclayton merged commit 3c90f22 into tuskyapp:develop Jul 6, 2023
@nikclayton nikclayton deleted the 3807-oob branch July 6, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlag charlag charlag left review comments

@connyduck connyduck connyduck approved these changes

@Tak Tak Awaiting requested review from Tak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ArrayIndexOutOfBoundsException in 23.0 beta 1
3 participants
@nikclayton @charlag @connyduck