Uses the system theme as default theme

[SpaceFox]

A small polish update to set the "System Design" as default theme.

This to avoid unexpected behaviour on first application usage, and to force the user to change settings few seconds only after the first Tusky opening – which is a quite bad first impression.

[nikclayton]

Just tried this, and it doesn't work as expected from a fresh install, because the default value, if the preference is missing, is 0, and that's less than the value it's being compared against.

So even with a fresh install you still get the dark theme.

Unfortunately, the two cases where the preference is missing are:

• this is a fresh install of the app
• the user is updating from a version before this schema version preference was introduced

There needs to be a mechanism to distinguish between those two cases.

It might be possible to do that by inspecting the database. I'll investigate tomorrow.

[nikclayton]

@SpaceFox Yeah -- simplest approach is probably, in TuskyApplication.kt:

1. Inject an AppDatabase instance
2. From the database instance, get an AccountDao instance, and call loadAll() on that

That'll return a list of accounts. If it's empty then this is a fresh install[1]. If it's not empty then this is an upgrade.

So something like (untested) around line 79 of TuskyApplication.kt:

val upgrading = db.accountDao().loadAll().isNotEmpty()
if (upgrading) {
    val oldVersion = sharedPreferences.getInt(PrefKeys.SCHEMA_VERSION, 0)
    if (oldVersion != SCHEMA_VERSION) {
        upgradeSharedPreferences(oldVersion, SCHEMA_VERSION)
    }
}

[1] There's a chance the user has also logged out of all their accounts, and is now logging in from scratch. That's probably sufficiently unlikely that we don't need to worry about it...

[connyduck]

Please don't overengineer this D:
Why not check the oldVersion in the preferences migration? If it is 0 its a new install

[nikclayton]

Please don't overengineer this D: Why not check the oldVersion in the preferences migration? If it is 0 its a new install

Ah, yeah, that'll do it :-)

[nikclayton]

Hi @SpaceFox , are you able to make the suggested changes?

[SpaceFox]

Hi,

I’m back from holidays, I pushed the suggested updates.

[nikclayton]

Thank you. Sorry it took longer than I'd like to check this out.

Just in case it's needed for future reference, I checked the following scenarios and it all behaves as expected:

Upgrade

• Wipe and install a fresh develop
• Don't change settings
• Update with PR
• Should still be dark theme

PASS

Upgrade with theme (black)

• Wipe and install a fresh develop
• Change theme to black
• Update with PR
• Should still be black theme

PASS

Upgrade with theme (dark)

• Wipe and install a fresh develop
• Explicitly set the theme to dark (e.g., set to black, exit prefs, then set back to dark)
• Update with PR
• Should still be dark theme

PASS

Fresh install, system theme is light

• Wipe and install from PR
• Should be light theme

PASS

Fresh install, system theme is dark

• Wipe and install from PR
• Should be dark theme

PASS