Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to androidx-media3 video player #3857

Merged
merged 46 commits into from
Aug 10, 2023
Merged

Migrate to androidx-media3 video player #3857

merged 46 commits into from
Aug 10, 2023

Commits on Feb 22, 2023

  1. Squash exoplayer draft branch. Uses exoplayer 2.18.3. Basic video pla… 

    …yback works. Play, ff, rew buttons are from inconsistent versions of the product (play is circular, rew and ff aren't). Video caption flickers weirdly.
    @mcclure
    mcclure committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    03846fc View commit details
    Browse the repository at this point in the history

  2. Move exoplayer branch to media3-exoplayer (squash commit)

    @mcclure
    mcclure committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    eb85fda View commit details
    Browse the repository at this point in the history

  3. Back out libs.versions.toml changes, upgrade to media3 rc01 and don't… 

    … use dash (consider rls if we add peertube later)
    @mcclure
    mcclure committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    cefb68c View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Make player look like media3 branch

    @mcclure
    mcclure committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    fa7063d View commit details
    Browse the repository at this point in the history

  2. Null commit to keep merges clean

    @mcclure
    mcclure committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    8530699 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Remerge develop->media3 branch

    @mcclure
    mcclure committed May 9, 2023
    Configuration menu
    Copy the full SHA
    cca34ad View commit details
    Browse the repository at this point in the history

  2. Upgrade exoplayer 1.0.0-rc01 to 1.0.1

    @mcclure
    mcclure committed May 9, 2023
    Configuration menu
    Copy the full SHA
    6e96576 View commit details
    Browse the repository at this point in the history

  3. ktLint

    @mcclure
    mcclure committed May 9, 2023
    Configuration menu
    Copy the full SHA
    30b8e4f View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Merge remote-tracking branch 'upstream/pull/3375/head' into media3

    Nik Clayton committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    ef0f822 View commit details
    Browse the repository at this point in the history

  2. Update to newest media3 library version

    Nik Clayton committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    1a416ac View commit details
    Browse the repository at this point in the history

  3. Use by viewBinding, eliminate _binding variable

    Nik Clayton committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    342002d View commit details
    Browse the repository at this point in the history

  4. Use OkHttp as the transport for media3

    Nik Clayton committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    0010f74 View commit details
    Browse the repository at this point in the history

  5. Additional debug logging for the player

    Nik Clayton committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    360989e View commit details
    Browse the repository at this point in the history

  6. Display playback errors

    Nik Clayton committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    05bf97d View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2023

  1. Use property access syntax

    Nik Clayton committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    2cca3e2 View commit details
    Browse the repository at this point in the history

  2. More property access syntax

    Nik Clayton committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    ef13ab9 View commit details
    Browse the repository at this point in the history

  3. Fix bug where the media description was being shown and hidden rapidly 

    Previous code didn't distinguish between a down and up motion event, so the description was being shown on the down and immediately removed on the up.
    Nik Clayton committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    108ffec View commit details
    Browse the repository at this point in the history

  4. Use the same timeout value (5 seconds) for the player controls and me… 

    …dia description
    Nik Clayton committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    18c59e4 View commit details
    Browse the repository at this point in the history

  5. Remove some dead comments

    Nik Clayton committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    cfcbdea View commit details
    Browse the repository at this point in the history

  6. Restore the "Continually display the media description when paused" f… 

    …unctionality
    Nik Clayton committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    76d475f View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Remove obsolete comments

    Nik Clayton committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    51509cf View commit details
    Browse the repository at this point in the history

  2. Remove empty onDestroyView

    Nik Clayton committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    90e396f View commit details
    Browse the repository at this point in the history

  3. Move mediaSourceFactory out of setupMediaView

    Nik Clayton committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    af8045e View commit details
    Browse the repository at this point in the history

  4. Properly release the player where necessary 

    This also means the player has to be recreated as necessary

- Make `player` property
- Release `player` in `onPause`
- Add initializePlayer() to do the initialisation and binding
    Nik Clayton committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    f4c9e51 View commit details
    Browse the repository at this point in the history

  5. LIfecycle stuff for API <= 23 and API > 23

    Nik Clayton committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    d30ab95 View commit details
    Browse the repository at this point in the history

  6. Save the seek position when pausing/stopping the fragment, restore it… 

    … when appropriate
    Nik Clayton committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    d4309e6 View commit details
    Browse the repository at this point in the history

  7. Remove obsolete comments

    Nik Clayton committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    557aed5 View commit details
    Browse the repository at this point in the history

  8. Move onCreateView and onViewCreated

    Nik Clayton committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    dfbf4e2 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Show more detailed error messages

    Nik Clayton committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    119f3f7 View commit details
    Browse the repository at this point in the history

  2. Rename media3 to androidx-media3

    Nik Clayton committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    400c73f View commit details
    Browse the repository at this point in the history

  3. Move the controls without needing a custom layout

    Nik Clayton committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    264ac91 View commit details
    Browse the repository at this point in the history

  4. ktlint

    Nik Clayton committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    3ae89bc View commit details
    Browse the repository at this point in the history

  5. Lint

    Nik Clayton committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    1596484 View commit details
    Browse the repository at this point in the history

  6. Move the companion object declaration to the bottom

    Nik Clayton committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    916605a View commit details
    Browse the repository at this point in the history

  7. Set up the gesture detectors on the video view (which is full screen)… 

    … not the root view
    Nik Clayton committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    220248d View commit details
    Browse the repository at this point in the history

  8. ViewMediaFragment does not need to be Injectable

    Nik Clayton committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    f4bf23c View commit details
    Browse the repository at this point in the history

  9. Remove obsolete ExposedPlayPauseVideoView

    Nik Clayton committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    f898ea1 View commit details
    Browse the repository at this point in the history

  10. Cleanup

    Nik Clayton committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    b28883b View commit details
    Browse the repository at this point in the history

  11. Don't crash if there's no view

    Nik Clayton committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    8c400c0 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Merge remote-tracking branch 'upstream/develop' into media3

    Nik Clayton committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    ffe0834 View commit details
    Browse the repository at this point in the history

  2. Set the preview (if it exists) as the media artwork

    Nik Clayton committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    668e84b View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Fix potential crash when image loading completes after the user hits … 

    …back
    Nik Clayton committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    26aef1a View commit details
    Browse the repository at this point in the history

  2. Ignore SyntheticAccessor lint warnings

    Nik Clayton committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    7f026e6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into media3

    Nik Clayton authored Jul 20, 2023
    Configuration menu
    Copy the full SHA
    feb2848 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Merge branch 'develop' into media3

    Nik Clayton authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    89f2a6f View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. Merge branch 'develop' into media3

    Nik Clayton authored Aug 6, 2023
    Configuration menu
    Copy the full SHA
    5da51cc View commit details
    Browse the repository at this point in the history