Structify ConfigOptions (apache#4517)

tustvold · Dec 29, 2022 · 4498533 · 4498533
1 parent 41c72cf
commit 4498533
Show file tree

Hide file tree

Showing 18 changed files with 611 additions and 868 deletions.
diff --git a/benchmarks/src/bin/h2o.rs b/benchmarks/src/bin/h2o.rs
@@ -63,7 +63,8 @@ async fn main() -> Result<()> {
 
 async fn group_by(opt: &GroupBy) -> Result<()> {
     let path = opt.path.to_str().unwrap();
-    let config = SessionConfig::from_env().with_batch_size(65535);
+    let mut config = SessionConfig::from_env()?;
+    config.config_options_mut().built_in.execution.batch_size = 65535;
 
     let ctx = SessionContext::with_config(config);
 

diff --git a/datafusion/core/src/bin/print_config_docs.rs b/datafusion/core/src/bin/print_config_docs.rs
@@ -15,9 +15,9 @@
 // specific language governing permissions and limitations
 // under the License.
 
-use datafusion::config::BuiltInConfigs;
+use datafusion::config::ConfigOptions;
 
 fn main() {
-    let docs = BuiltInConfigs::generate_config_markdown();
+    let docs = ConfigOptions::generate_config_markdown();
     println!("{}", docs);
 }
diff --git a/datafusion/core/src/catalog/information_schema.rs b/datafusion/core/src/catalog/information_schema.rs
@@ -27,7 +27,7 @@ use arrow::{
     record_batch::RecordBatch,
 };
 
-use crate::config::ConfigOptions;
+use crate::config::{ConfigEntry, ConfigOptions};
 use crate::datasource::streaming::{PartitionStream, StreamingTable};
 use crate::datasource::TableProvider;
 use crate::execution::context::TaskContext;
@@ -162,8 +162,8 @@ impl InformationSchemaConfig {
         config_options: &ConfigOptions,
         builder: &mut InformationSchemaDfSettingsBuilder,
     ) {
-        for (name, setting) in config_options.options() {
-            builder.add_setting(name, setting.to_string());
+        for entry in config_options.entries() {
+            builder.add_setting(entry);
         }
     }
 }
@@ -611,7 +611,7 @@ impl InformationSchemaDfSettings {
     fn new(config: InformationSchemaConfig) -> Self {
         let schema = Arc::new(Schema::new(vec![
             Field::new("name", DataType::Utf8, false),
-            Field::new("setting", DataType::Utf8, false),
+            Field::new("setting", DataType::Utf8, true),
         ]));
 
         Self { schema, config }
@@ -656,9 +656,9 @@ struct InformationSchemaDfSettingsBuilder {
 }
 
 impl InformationSchemaDfSettingsBuilder {
-    fn add_setting(&mut self, name: impl AsRef<str>, setting: impl AsRef<str>) {
-        self.names.append_value(name.as_ref());
-        self.settings.append_value(setting.as_ref());
+    fn add_setting(&mut self, entry: ConfigEntry) {
+        self.names.append_value(entry.key);
+        self.settings.append_option(entry.value);
     }
 
     fn finish(&mut self) -> RecordBatch {