Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign labels #7756

Closed
23 tasks done
Tracked by #318
charlag opened this issue Oct 17, 2024 · 0 comments · Fixed by #7853
Closed
23 tasks done
Tracked by #318

Assign labels #7756

charlag opened this issue Oct 17, 2024 · 0 comments · Fixed by #7853
Assignees
@hrb-hub
Labels
feature: labels goal: email for business no-release-notes (excluded from release notes) state:tested We tested it and are about to release it
Milestone
252.11.22 (Label ...

Comments

@charlag
Copy link
Contributor

charlag commented Oct 17, 2024 •
edited by hrb-hub
Loading

part of #318
estimated: 16h
spent: 7h + 4h + 2h + 0.5h + 1h = 14.5h

Tasks:

  • Backend service
  • Converstaion viewer
  • List view (multi select)
  • Add an icon when label applied to some emails

Test notes

  • There is a button to assign labels in mail view
    • In desktop layout in the toolbar for a single mail
    • In desktop layout in the toolbar for multiselect
    • In more menu for individual mails
    • In mobile layout in the toolbar for a single mail
    • In mobile layout in the toolbar for multiselect
  • There is a button to assign labels in search view
    • In desktop layout in the toolbar for a single mail
    • In desktop layout in the toolbar for multiselect
    • In more menu for individual mails
    • In mobile layout in the toolbar for a single mail
    • In mobile layout in the toolbar for multiselect
  • Dropdown shows all the labels and their status
  • In case of multiselect if some mails don't have the label assigned and some do there is a label icon with a dash in the middle
  • Only labels that are completely selected or deselected in the dropdown will change, partially applied ones don't change
  • Folders don't change when changing labels
  • Dropdown to apply labels does not overflow
  • Dropdown to apply labels can be navigated with keyboard and screen reader, it traps focus correctly
  • If dropdown is dismissed no labels are applied
@charlag charlag mentioned this issue Oct 17, 2024
Closed
30 tasks
@wrdhub wrdhub mentioned this issue Oct 29, 2024
Closed
BijinDev added a commit that referenced this issue Nov 1, 2024
@BijinDev @charlag @wrdhub
Support partially applied labels
833d7ab 
#7756

Co-authored-by: ivk <ivk@tutao.de>
Co-authored-by: wrd <wrd@tutao.de>
BijinDev added a commit that referenced this issue Nov 1, 2024
@BijinDev @charlag
Support partially applied labels
90c859a 
#7756

Co-authored-by: ivk <ivk@tutao.de>
BijinDev pushed a commit that referenced this issue Nov 1, 2024
@charlag @BijinDev
Assign labels
5b989fb 
Model changes for assigning labels.
Adjust saturation for displaying labels in dark themes.

#7756

Co-authored-by: ivk <ivk@tutao.de>
@BijinDev BijinDev mentioned this issue Nov 1, 2024
Merged
@wrdhub wrdhub linked a pull request Nov 5, 2024 that will close this issue
Assign labels #7853
Merged
@charlag charlag mentioned this issue Nov 5, 2024
Closed
5 tasks
@wrdhub wrdhub added this to the Labels milestone Nov 5, 2024
@charlag charlag modified the milestones: Labels, Next client release Nov 21, 2024
@charlag charlag closed this as completed Nov 21, 2024
@charlag charlag added the no-release-notes (excluded from release notes) label Nov 22, 2024
@hrb-hub hrb-hub self-assigned this Nov 22, 2024
@hrb-hub hrb-hub added the state:tested We tested it and are about to release it label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hrb-hub hrb-hub

Labels
feature: labels goal: email for business no-release-notes (excluded from release notes) state:tested We tested it and are about to release it
Projects
None yet
Milestone
252.11.22 (Label support)
Development

Successfully merging a pull request may close this issue.

Assign labels tutao/tutanota
4 participants
@charlag @wrdhub @hrb-hub @BijinDev