Show mails with currently selected label #7882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrb-hub
force-pushed
the
7760-show-mail-with-label
branch
from
ab0ab70 to
4b97ae3
Compare
16 tasks
wrdhub
requested changes
Nov 6, 2024
There was a problem hiding this comment.
I think the code looks good, I just noticed a few issues while smoke testing:
- In edit mode, the selected label is still highlighted and selecting a label opens that group in the background. (The selected label should not be highlighted and clicking on a label should do nothing).
- When having a label selected, I think it would be nice to have the folder icon on mails in the mail list, like in search.
- When having multiple mails selected, clicking on move folders the folder that the first mail is in is not shown. I think all folders should be shown. (This is not unique to this though, it is also an issue in search so maybe it should be a separate issue).
wrdhub
force-pushed
the
label-integration
branch
from
d69fa4a to
a6812bb
Compare
charlag
reviewed
Nov 7, 2024
hrb-hub
force-pushed
the
7760-show-mail-with-label
branch
3 times, most recently
from
a5a00da to
f6cc7b9
Compare
charlag
approved these changes
Nov 7, 2024
hrb-hub
force-pushed
the
7760-show-mail-with-label
branch
from
f6cc7b9 to
eef95dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #7760