Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option failure_limit does not work #19

Closed
BrandonKahre opened this issue Jan 18, 2012 · 1 comment
Closed

Option failure_limit does not work #19

BrandonKahre opened this issue Jan 18, 2012 · 1 comment

Comments

@BrandonKahre
Copy link

When the failure_limit option was added back on Dec-01, the code to maintain backwards compatibility was added incorrectly. The code checks for option.failurelimit to not strictly equal null. If the option is omitted (as it should be going forward), the check still returns true (null !== undefined) and then incorrectly overrides any specified value for option.failurelimit to 0. I believe the proper check should be:

if (undefined !== options.failurelimit) {}

@tuupola
Copy link
Owner

tuupola commented Jan 19, 2012

Fixed. Thanks for the heads up.

@tuupola tuupola closed this as completed Jan 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants