Fix inversed colour temperature. #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The colour temperature was inversed so when you picked warm in the ui the lightbulb would turn cold and vice versa. This is because the range of 140-500 in homekit is inverse to the 0-1000 range of the lightbulb, in fact the values 140-500 are micro-reciprocal degrees (mired), which is 1,000,000 divided by the color temperature in kelvins. I've adjusted the range conversions for colour temperature to convert to and from the range 2000K-14285K which when converted to mireds corresponds to about 70-500 inversed. I've also added a little trick extending the colour temperature characteristics range to 70-500 in order to show a ui that has a nice orange-blue gradient. Hence I used the values 70-500 in the calculations as well.
|
I look forward to seeing this fix in the release. I have noticed the same problem. |
|
I also see this problem on my side! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The colour temperature was inversed so when you picked warm in the ui the lightbulb would turn cold and vice versa. This is because the range of 140-500 in homekit is inverse to the 0-1000 range of the lightbulb, in fact the values 140-500 are micro-reciprocal degrees (mired), which is 1,000,000 divided by the color temperature in kelvins.
I've adjusted the range conversions for colour temperature to convert to and from the range 2000K-14285K which when converted to mireds corresponds to about 70-500 inversed.
I've also added a little trick extending the colour temperature characteristics range to 70-500 in order to show a ui that has a nice orange-blue gradient. Hence I used the values 70-500 in the calculations as well.