Small fixes #1
Open
Small fixes #1
+125
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also support Const. Its raw raw constvalue is printed, even if it's somewhat of limited value.
|
@tvondra Any thoughts on picking these up? I'm considering adopting this and making it tolerant of different Pg versions. |
|
13.11.2019 04:29, Craig Ringer пишет:
@tvondra <https://github.com/tvondra> Any thoughts on picking these up?
I'm considering adopting this and making it tolerant of different Pg
versions.
+1. I use it every day for PG v.10, 11.5 and 12. I can help in this work.
…--
Andrey Lepikhov
Postgres Professional
https://postgrespro.com
The Russian Postgres Company
|
|
I'll be happy to help too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tomas,
Thanks a lot for this tool!
Here are some patch to fix some issues I faced while using gdbpg on current HEAD. I also added some more information wrt partitioning (I may need to add some more shortly). Also, I had to drop the has_fk_join field. I looked in the git history but couldn't find any reference to it (was it present at some point while working on 137805f89acb361144ec98d9847e26d2848aa57e ?), so if I missed it and it just has been renamed at some point, please tell me and I'll fix.