Skip to content

Commit

Permalink
Depend on sassc-rails, specify required_ruby_version
Browse files Browse the repository at this point in the history
  • Loading branch information
glebm committed Dec 20, 2018
1 parent 2277fb3 commit 804e3dd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
language: ruby
sudo: false
rvm:
- 2.3.1
- 2.3.8
gemfile:
- test/gemfiles/rails_4_2.gemfile
- test/gemfiles/rails_5_0.gemfile
Expand Down
5 changes: 4 additions & 1 deletion bootstrap.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,12 @@ Gem::Specification.new do |s|
s.homepage = 'https://github.com/twbs/bootstrap-rubygem'
s.license = 'MIT'

# SassC requires Ruby 2.3.3. Also specify here to make it obvious.
s.required_ruby_version = '>= 2.3.3'

s.add_runtime_dependency 'popper_js', '>= 1.14.3', '< 2'

s.add_runtime_dependency 'sassc', '>= 1.12.1'
s.add_runtime_dependency 'sassc-rails', '>= 2.0.0'

This comment has been minimized.

Copy link
@betelgeuse

betelgeuse Dec 31, 2018

Why this change? Isn't bootstrap supposed to be usable outside rails in frameworks like sinatra?

s.add_runtime_dependency 'autoprefixer-rails', '>= 9.1.0'

# Testing dependencies
Expand Down
1 change: 1 addition & 0 deletions lib/bootstrap/engine.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# frozen_string_literal: true

require 'autoprefixer-rails'
require 'sassc-rails'

module Bootstrap
module Rails
Expand Down

0 comments on commit 804e3dd

Please sign in to comment.