Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: Upgrade to node-sass ~3.4.2 #987

Merged
merged 2 commits into from
Nov 23, 2015
Merged

package.json: Upgrade to node-sass ~3.4.2 #987

merged 2 commits into from
Nov 23, 2015

Conversation

cvrebert
Copy link
Collaborator

Fixes #986.

@cvrebert cvrebert added this to the v3.3.6 milestone Nov 18, 2015
@cvrebert
Copy link
Collaborator Author

@twbs/sass Ping.

@glebm
Copy link
Member

glebm commented Nov 23, 2015

LGTM

@@ -9,6 +9,7 @@ gemfile:
- test/gemfiles/sass_3_4.gemfile
- test/gemfiles/sass_head.gemfile
before_install:
- "nvm install stable"
- "npm install"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need both install stable and install?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nVmnPm

cvrebert added a commit that referenced this pull request Nov 23, 2015
package.json: Upgrade to node-sass ~3.4.2
@cvrebert cvrebert merged commit db694ef into master Nov 23, 2015
@cvrebert cvrebert deleted the bump-node-sass branch November 23, 2015 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants