Skip to content

Commit

Permalink
drop flex and max-width, just use width
Browse files Browse the repository at this point in the history
  • Loading branch information
mdo committed Apr 7, 2017
1 parent c6168b6 commit 2436ad5
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions scss/mixins/_grid.scss
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,7 @@
}

@mixin make-col($size, $columns: $grid-columns) {
flex: 0 0 percentage($size / $columns);
// width: percentage($size / $columns);
// Add a `max-width` to ensure content within each column does not blow out
// the width of the column. Applies to IE10+ and Firefox. Chrome and Safari
// do not appear to require this.
max-width: percentage($size / $columns);
width: percentage($size / $columns);
}

@mixin make-col-offset($size, $columns: $grid-columns) {
Expand Down

2 comments on commit 2436ad5

@sachinsinghi
Copy link

@sachinsinghi sachinsinghi commented on 2436ad5 May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mdo,
Removing max-width and flex intorduced a defect for "Variable width content". It does not work anymore as the .col has flex-grow:1 and flex-basis:0 and max-width:100%. Please advise if this is intentional.

@mdo
Copy link
Member Author

@mdo mdo commented on 2436ad5 May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open an issue please?

Please sign in to comment.