Skip to content

Commit

Permalink
v5: Fix disabled styling on .form-file (#29022)
Browse files Browse the repository at this point in the history
While #28450 overhauled a ton of forms work, the  support for this custom file input was ineffective. This updates the selector to target the custom field and gray out the entire field.

Fixes #28176.
  • Loading branch information
mdo authored and XhmikosR committed Jul 14, 2019
1 parent 6a9fd74 commit cef69b9
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
2 changes: 1 addition & 1 deletion scss/forms/_form-file.scss
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

// Use disabled attribute instead of :disabled pseudo-class
// Workaround for: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/11295231
&[disabled] ~ .form-file-label {
&[disabled] ~ .form-file-label .form-file-text {
background-color: $form-file-disabled-bg;
}
}
Expand Down
12 changes: 12 additions & 0 deletions site/content/docs/4.3/forms/file.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,18 @@ The file input is the most gnarly of the bunch and requires additional JavaScrip
</div>
{{< /example >}}

Add the `disabled` attribute to the `<input>` and the custom markup will be updated to appear disabled.

{{< example >}}
<div class="form-file">
<input type="file" class="form-file-input" id="customFileDisabled" disabled>
<label class="form-file-label" for="customFileDisabled">
<span class="form-file-text">Choose file...</span>
<span class="form-file-button">Browse</span>
</label>
</div>
{{< /example >}}

Longer placeholder text is truncated and an ellipsis is added when there's not enough space.

{{< example >}}
Expand Down

0 comments on commit cef69b9

Please sign in to comment.