idea: issues bot that points out live examples whose HTML doesn't validate

[cvrebert]

[Edit: See https://github.com/cvrebert/lmvtfy !]

[zlatanvasovic]

Can you describe idea a bit more? 😄

[cvrebert]

A bot that scans for newly posted comments with JS Fiddle or JS Bin links, extracts the HTML portion of the Fiddle/Bin, runs it thru the HTML5 validator, and posts a follow-up comment listing any validation errors.

We get a decent number of "bug" reports where the problem is actually due to invalid HTML.

[zlatanvasovic]

Ok, I understand now.

[mdo]

That'd be interesting, but we have to be careful with whatever bot we come up with. It was too easy the last time for someone to accidentally comment on a huge set of issues with the wrong comment.

[cvrebert]

Unlike the old haunt script, I definitely wouldn't make the bot a Grunt task or have it in the main Bootstrap repo.

[mdo]

👍

[cvrebert]

Other useful bot: One that points out PRs against the gh-pages branch.

[zlatanvasovic]

Yea. +1

2014/1/8 Chris Rebert notifications@github.com

Other useful bot: One that points out PRs against the gh-pages branch.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/11984#issuecomment-31804477
.

Zlatan Vasović - ZDroid

[cvrebert]

• Also, flag pull requests that edit only dist CSS files and not any of the less source code.

[zlatanvasovic]

And pull requests that edit only dist JS files and not any of the JS source
code.

2014-04-27 10:03 GMT+02:00 Chris Rebert notifications@github.com:

• Also, flag pull requests that edit only dist CSS files and not any
  of the less source code.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/11984#issuecomment-41490654
.

Zlatan Vasović - ZDroid

[hnrch02]

+:100: Maybe try and resurrect fat/haunt?
(What happened to that anyway? 2.1.1 had it and 2.2.0 didn't.)

[hnrch02]

/cc @fat

[cvrebert]

@hnrch02 It got removed in 92e7f16. AFAIK, Haunt stopped being used because (a) it was too trigger-happy and incorrectly auto-closed a number of legitimate issues (b) since the code for it was in the main repo, some folks would run it themselves by mistake or out of curiosity, resulting in some comment spam.

Also, it wasn't a real-time always-on service, so there was the inconvenience of having to run it manually on a periodic basis.

[hnrch02]

@cvrebert Yeah, flipped through the issues of haunt and read that a few people were unintentionally commenting on some of Bootstrap's issues. Anyway, I'll watch cvrebert/lmvtfy closely and see if I can help there 😃

[cvrebert]

Almost ready to launch!

[zlatanvasovic]

I hope it'll be ready soon. :P

I want to test it.

2014-06-15 11:33 GMT+02:00 Chris Rebert notifications@github.com:

Almost ready to launch!

—
Reply to this email directly or view it on GitHub
#11984 (comment).

Zlatan Vasović - ZDroid

[cvrebert]

@zdroid You can test it right now. I have it running on https://github.com/cvrebert/lmvtfy-test/issues at the moment.

[zlatanvasovic]

Nice.

2014-06-15 11:49 GMT+02:00 Chris Rebert notifications@github.com:

@zdroid https://github.com/ZDroid You can test it right now. I have it
running on https://github.com/cvrebert/lmvtfy-test/issues at the moment.

—
Reply to this email directly or view it on GitHub
#11984 (comment).

Zlatan Vasović - ZDroid

[hnrch02]

@cvrebert Fantastic work as always.

[cvrebert]

And now for the live demo to ensure that the production deploy was successful...
http://jsfiddle.net/V49NM/

[cvrebert]

Take 2: http://jsfiddle.net/V49NM/

[cvrebert]

Okay, after faffing about with backslashes in the WebHook secret key, this ought to work:
http://jsfiddle.net/V49NM/

[twbs-lmvtfy]

Hi @cvrebert!

You appear to have posted a live example (http://jsfiddle.net/V49NM/show/), which is always a good first step.
However, according to the HTML5 validator, your example has some validation errors, which might be causing your issue:

• line 30, column 34: Attribute href not allowed on HTML element span at this point.
• line 32, column 7: HTML element p not allowed as child of HTML element ul in this context. (Suppressing further errors from this subtree.)

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!

(Please note that this is a fully automated comment.)

[hnrch02]

Yay!

[cvrebert]

Huzzah!
Closing since successfully deployed to production!
There are a few TODOs (see https://github.com/cvrebert/lmvtfy/issues), but this should be fine for v1.
@mdo Lemme know if you want any tweaks to the copy.

[zlatanvasovic]

Works well. GJ.

2014-06-16 6:36 GMT+02:00 Chris Rebert notifications@github.com:

Closed #11984 #11984.

—
Reply to this email directly or view it on GitHub
#11984 (comment).

Zlatan Vasović - ZDroid

[thomaswelton]

So badass

[mdo]

@cvrebert Only comment on copy is the line breaks without an empty line between:

You appear to have posted a live example (http://jsfiddle.net/V49NM/show/), which is always a good first step.
However, according to the HTML5 validator, your example has some validation errors, which might be causing your issue:

Though, in that specific example, I'd make it all one paragraph.

Otherwise, this is super fucking awesome. Well done, sir! <3

(Perhaps you'd want to write a post for the blog to highlight it? Or we can tweet about it from Bootstrap?)

[twbs-lmvtfy]

Hi @mdo!

You appear to have posted a live example (http://jsfiddle.net/V49NM/show/), which is always a good first step.
However, according to the HTML5 validator, your example has some validation errors, which might be causing your issue:

• line 30, column 34: Attribute href not allowed on HTML element span at this point.
• line 32, column 7: HTML element p not allowed as child of HTML element ul in this context. (Suppressing further errors from this subtree.)

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!

(Please note that this is a fully automated comment.)

[hnrch02]

Impressively fast, too 😁

[mdo]

Also, that might be a bug. Originally I had the link in a triple backtick code block and the bot called it out. Probably want to avoid doing that for quotes and links in code blocks?

[cvrebert]

I think cvrebert/lmvtfy#5 will cover it?

[cvrebert]

(Perhaps you'd want to write a post for the blog to highlight it? Or we can tweet about it from Bootstrap?)

Hells yeah.

[cvrebert]

Checking that the redeploy went okay: http://run.plnkr.co/plunks/ldtFIUs7Pd5ahdnOFFfq/

[twbs-lmvtfy]

Hi @cvrebert!

You appear to have posted a live example (http://run.plnkr.co/plunks/ldtFIUs7Pd5ahdnOFFfq/), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might be causing your issue:

• line 7, column 9: Element head is missing a required instance of child element title.
• line 11, column 7: Element p not allowed as child of element ul in this context. (Suppressing further errors from this subtree.)

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!

(Please note that this is a fully automated comment.)