Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card headers / footers not inheriting styling from .card-outline-variant #22056

Closed
shamoon opened this issue Feb 23, 2017 · 0 comments
Closed

Comments

@shamoon
Copy link

shamoon commented Feb 23, 2017

Seems to me that .card-outline-variant should pass this rather specific styling down to its usual descendants .card-header and .card-footer in the same way that .card-primary affects styling of these divs. Instead, at the moment you wound need to apply .card-outline-variant to the descendant divs themselves for them to have the same styling of the card.

Agreed?

Before:
current

After:
proposed

Simple fix is to add a few lines to the 'card-outline-variant' mixin, mixins/_cards.scss:

  .card-header,
  .card-footer {
     background-color: transparent;
     border-color: $color;
  }
@mdo mdo added this to the v4.0.0-beta.2 milestone Mar 28, 2017
@mdo mdo added the has-pr label Apr 9, 2017
mdo added a commit that referenced this issue Apr 9, 2017
Fixes #22056 by ensuring outline cards make their header/footer transparent and use the right border color.
@mdo mdo modified the milestones: v4.0.0-beta, v4.0.0-beta.2 Apr 9, 2017
@mdo mdo closed this as completed in #22394 Apr 9, 2017
mdo added a commit that referenced this issue Apr 9, 2017
Fixes #22056 by ensuring outline cards make their header/footer transparent and use the right border color.
@mdo mdo mentioned this issue Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants