Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace base64 gif placeholder images with SVG ones #23185

Closed
XhmikosR opened this issue Jul 31, 2017 · 8 comments
Closed

Replace base64 gif placeholder images with SVG ones #23185

XhmikosR opened this issue Jul 31, 2017 · 8 comments

Comments

@XhmikosR
Copy link
Member

Currently we use gif base64 placeholder images in a few pages. We should switch to SVGs.

@bardiharborow
Copy link
Member

I don't overly mind either way, but as the person who designed those GIFs, I'll just provide some context. I designed those GIFs to replace the previous base64-encoded images that were heavily suboptimal. The GIFs are the smallest 1x1px image file possible, and IIRC were stolen from mathiasbynens/small and manually hexedited to be the correct color. I'm happy to replace with SVG alternatives, but I'm not sure what the point would be.

@bardiharborow
Copy link
Member

@XhmikosR You've said over in #23186 that you don't want the SVGs base64 encoded. Isn't the whole point of base64 encoding so that you can still use <img> tags and users of the template can quickly swap in an image of their own without having to replace inline svg? Or maybe that's really not an important use-case.

@XhmikosR
Copy link
Member Author

Sure, but this is a one-time thing we need to do. The SVG doesn't need to be readable since it's just a few characters long.

@XhmikosR
Copy link
Member Author

Generally the SVG will be smaller than the current gif. Compression will be slightly better and there's no reason not to use SVGs everywhere anymore. :)

@Varunram
Copy link
Contributor

@XhmikosR can we close this? :)

@XhmikosR
Copy link
Member Author

Nope, still a valid request :)

@Varunram
Copy link
Contributor

Oh no, strike 2 :( I thought there were no gifs left, my bad

@XhmikosR
Copy link
Member Author

Yeah, I never got to look into it, although there's a PR available too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants