-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace base64 gif placeholder images with SVG ones #23185
Comments
I don't overly mind either way, but as the person who designed those GIFs, I'll just provide some context. I designed those GIFs to replace the previous base64-encoded images that were heavily suboptimal. The GIFs are the smallest 1x1px image file possible, and IIRC were stolen from mathiasbynens/small and manually hexedited to be the correct color. I'm happy to replace with SVG alternatives, but I'm not sure what the point would be. |
@XhmikosR You've said over in #23186 that you don't want the SVGs base64 encoded. Isn't the whole point of base64 encoding so that you can still use |
Sure, but this is a one-time thing we need to do. The SVG doesn't need to be readable since it's just a few characters long. |
Generally the SVG will be smaller than the current gif. Compression will be slightly better and there's no reason not to use SVGs everywhere anymore. :) |
@XhmikosR can we close this? :) |
Nope, still a valid request :) |
Oh no, strike 2 :( I thought there were no gifs left, my bad |
Yeah, I never got to look into it, although there's a PR available too. |
Currently we use gif base64 placeholder images in a few pages. We should switch to SVGs.
The text was updated successfully, but these errors were encountered: