Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel example: use pure CSS when possible. #27593

Closed
wants to merge 3 commits into from
Closed

Carousel example: use pure CSS when possible. #27593

wants to merge 3 commits into from

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Nov 4, 2018

Fixes #23185

@XhmikosR XhmikosR requested a review from a team as a code owner November 4, 2018 16:51
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-carousel-example branch from baf6b86 to fe6f1aa Compare November 5, 2018 06:59
@XhmikosR
Copy link
Member Author

XhmikosR commented Nov 5, 2018

@MartijnCuppens: I split the changes so that we can choose individual ones if needed.

I'm not sure about the background-color move yet, because it's actually handy to see the various issues I noticed :)

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-carousel-example branch from fe6f1aa to d7e6771 Compare November 9, 2018 15:11
@XhmikosR
Copy link
Member Author

XhmikosR commented Nov 9, 2018

On hold for now since after #27632 we can use that.

@XhmikosR
Copy link
Member Author

Closing this for now and I'll make the changes in #27633

@XhmikosR XhmikosR closed this Nov 20, 2018
@XhmikosR XhmikosR deleted the v4-dev-xmr-carousel-example branch November 20, 2018 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens Awaiting requested review from MartijnCuppens

Assignees
No one assigned
Labels
examples on-hold v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@XhmikosR