You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On _varibles.scss there are several definitions of margins and paddings, and although the numbers are consistant, it is really hard to change one and keep consistency across all components.
I want to suggest that we introduce a set of component spacer variables with different sizes that will rule all components paddings and margins. That way by changing the variables in one place we'd have full control of all components and keep them consistant.
This feels like an unnecessary abstraction right now. The example here at least doesn't seem to buy us more, and adds one more layer to the input-button variables. Passing for now I think.
On
_varibles.scss
there are several definitions of margins and paddings, and although the numbers are consistant, it is really hard to change one and keep consistency across all components.I want to suggest that we introduce a set of component spacer variables with different sizes that will rule all components paddings and margins. That way by changing the variables in one place we'd have full control of all components and keep them consistant.
For example we have now:
And I want to change it to:
We can even use the same $spacer mapping to generate them so utility classes follow the same meassurements we use on components.
You can read more about it here:
https://medium.com/eightshapes-llc/space-in-design-systems-188bcbae0d62
This is a large change that requieres a lot of testing, if you guys are ok with it, I can send a PR to see how it looks,
What do you think?
The text was updated successfully, but these errors were encountered: