Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create component shadow variables to keep consistency across components #23775

Closed
andresgalante opened this issue Aug 31, 2017 · 2 comments · Fixed by #29023
Closed

Create component shadow variables to keep consistency across components #23775

andresgalante opened this issue Aug 31, 2017 · 2 comments · Fixed by #29023

Comments

@andresgalante
Copy link
Collaborator

We are defining different shadows in different components. There are about 25 shadow definitions on variables.

To keep consistency, I think we unify all of them in 4 shadow variables (sm, md, lg and inset) and then reuse them across components.

For example, instead of:

$popover-box-shadow:                  0 .3rem .6rem rgba($black,.2) 

We would have something like:

$component-box-shadow-md:                  0 .3rem .6rem rgba($black,.2) 
$popover-box-shadow:                  $component-box-shadow-md 

This follows the same idea as #23674

Before I send a PR I'd like to know what do you guys think?

@mdo
Copy link
Member

mdo commented Oct 2, 2017

I'm down!

@mdo
Copy link
Member

mdo commented Jul 13, 2019

Revisiting this, I've put some existing box-shadow variables that we added awhile ago better use. See #29023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants