We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We are defining different shadows in different components. There are about 25 shadow definitions on variables.
To keep consistency, I think we unify all of them in 4 shadow variables (sm, md, lg and inset) and then reuse them across components.
For example, instead of:
$popover-box-shadow: 0 .3rem .6rem rgba($black,.2)
We would have something like:
$component-box-shadow-md: 0 .3rem .6rem rgba($black,.2) $popover-box-shadow: $component-box-shadow-md
This follows the same idea as #23674
Before I send a PR I'd like to know what do you guys think?
The text was updated successfully, but these errors were encountered:
I'm down!
Sorry, something went wrong.
Revisiting this, I've put some existing box-shadow variables that we added awhile ago better use. See #29023.
box-shadow
Successfully merging a pull request may close this issue.
We are defining different shadows in different components. There are about 25 shadow definitions on variables.
To keep consistency, I think we unify all of them in 4 shadow variables (sm, md, lg and inset) and then reuse them across components.
For example, instead of:
We would have something like:
This follows the same idea as #23674
Before I send a PR I'd like to know what do you guys think?
The text was updated successfully, but these errors were encountered: