Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of .valid-feedback, .valid-tooltip and .invalid-tooltip #24811

Closed
ysds opened this issue Nov 17, 2017 · 1 comment
Closed

Add example of .valid-feedback, .valid-tooltip and .invalid-tooltip #24811

ysds opened this issue Nov 17, 2017 · 1 comment

Comments

@ysds
Copy link
Member

ysds commented Nov 17, 2017

The example of .valid-feedback, .valid-tooltip and .invalid-tooltip does not seem to be in the document. Should we add these examples? especially it would be useful to clarify how to use invalid/valid-tooltip. Thanks.

Related SCSS:

.#{$state}-feedback {
display: none;
margin-top: $form-feedback-margin-top;
font-size: $form-feedback-font-size;
color: $color;
}
.#{$state}-tooltip {
position: absolute;
top: 100%;
z-index: 5;
display: none;
width: 250px;
padding: .5rem;
margin-top: .1rem;
font-size: .875rem;
line-height: 1;
color: #fff;
background-color: rgba($color, .8);
border-radius: .2rem;
}

@tmorehouse
Copy link
Contributor

.valid-feedbck works nicely, although not sure about invalid or valid tooltip. It appears to make a fixed width (250px) red or green background behind the tooltip, rather than changing the tooltip background color.

mdo added a commit that referenced this issue Dec 30, 2017
Fixes #24811.

This adds .valid-feedback to our custom styles and server side examples; previously we ommitted this to suggest you don't always need valid feedback. In addition, this adds examples of the .{valid|invalid}-tooltip classes with a new subsection in the Validation docs.
@mdo mdo added the has-pr label Dec 30, 2017
@mdo mdo closed this as completed in #25143 Jan 3, 2018
mdo added a commit that referenced this issue Jan 3, 2018
* Add additional form validation examples

Fixes #24811.

This adds .valid-feedback to our custom styles and server side examples; previously we ommitted this to suggest you don't always need valid feedback. In addition, this adds examples of the .{valid|invalid}-tooltip classes with a new subsection in the Validation docs.

* Update validation tooltip styles to remove fixed width; instead should retain itself to the parent element

* update ids

* finish docs paragraph, mention position: relative
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants