Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

position:sticky inside accordion #28873

Closed
PatrickRose opened this issue Jun 5, 2019 · 0 comments · Fixed by #32013
Closed

position:sticky inside accordion #28873

PatrickRose opened this issue Jun 5, 2019 · 0 comments · Fixed by #32013
Labels
css

Comments

@PatrickRose
Copy link

  • Operating system and version: Linux
  • Browser and version: Chrome 73 (but reproducible on all browsers)
  • Reduced test case with fix

In #27133 to remove the double border at the bottom, cards inside an accordion got overflow: hidden done. This means that position: sticky doesn't work (my guess is that because the browser is hiding things that are overflowing, sticky doesn't trigger?).

The codepen attached replaces that with a removal of the border - since that's what we're actually trying to achieve but I'm not 100% sure that's the right solution.
@gijsroge gijsroge mentioned this issue Jan 17, 2020
Closed
7 tasks
gijsroge pushed a commit to gijsroge/bootstrap that referenced this issue Feb 11, 2020
Remove overflow hidden to support position sticky inside accordions. F…
99e6f1c 
…ixes twbs#28873

Also fixes twbs#28134 as we move the border from the header to the body and no longer have a overlapping issue of the header bottom.
@mdo mdo mentioned this issue Oct 30, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css
Projects
None yet
Milestone
No milestone
2 participants
@PatrickRose @MartijnCuppens