Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select uses wrong border variable for height calculation #21994

Conversation

andrewbelcher
Copy link

@andrewbelcher andrewbelcher commented Feb 15, 2017

To get selects matching the size of text inputs, a calculation is done which includes the width of the border. However, it uses $border-width instead of $input-btn-border-width, which means if the two don't match, your selects have the wrong height.

Fixes #22011.

@mdo
Copy link
Member

mdo commented Mar 3, 2017

#22068 was merged as an alternate fix for this. Thanks!

@mdo mdo closed this Mar 3, 2017
@mdo mdo removed this from the v4.0.0-beta milestone Mar 3, 2017
@andrewbelcher andrewbelcher deleted the andrewbelcher-select-border-fix branch March 17, 2017 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants