Add cursor: pointer to .navbar-toggler #22070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the toggler doesn't have the pointer icon as you would expect.
houndci-bot
reviewed
Feb 26, 2017
scss/_navbar.scss
Outdated
| @@ -88,6 +88,7 @@ | |||
| .navbar-toggler { | |||
| align-self: flex-start; // Prevent toggler from growing to full width when it's the only visible navbar child | |||
| padding: $navbar-toggler-padding-y $navbar-toggler-padding-x; | |||
| cursor: pointer; | |||
There was a problem hiding this comment.
Properties should be ordered align-self, padding, font-size, line-height, cursor, background, border
|
I removed the cursor pointer from buttons in another #21812. Might end up restoring them, but this wouldn't be necessary if we did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the toggler doesn't have the pointer icon as you would expect.