Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach accordion from card #22138

Merged
merged 3 commits into from
Mar 20, 2017
Merged

Detach accordion from card #22138

merged 3 commits into from
Mar 20, 2017

Conversation

Johann-S
Copy link
Member

@Johann-S Johann-S commented Mar 9, 2017

  • Add unit test

/CC : @mdo @bardiharborow

Closes : #22025

@Johann-S
Copy link
Member Author

Johann-S commented Mar 9, 2017

For me everything is done here @mdo except the documentation

@Johann-S
Copy link
Member Author

Only JavaScript here @bardiharborow no CSS for the labels

@mdo
Copy link
Member

mdo commented Mar 11, 2017

Only JavaScript here @bardiharborow no CSS for the labels

Whenever something affects or is related to the CSS (in this case the .collapse classes), we generally apply the CSS label :). This does need the JS one, too, though!

@mdo mdo added the js label Mar 11, 2017
@mdo
Copy link
Member

mdo commented Mar 11, 2017

I'll take a stab at adding some docs examples here shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants