Collapse - do not prevent event for input #22272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine by me! |
pvdlg
reviewed
Mar 26, 2017
js/src/collapse.js
Outdated
| @@ -363,7 +363,9 @@ const Collapse = (($) => { | |||
| */ | |||
|
|
|||
| $(document).on(Event.CLICK_DATA_API, Selector.DATA_TOGGLE, function (event) { | |||
| event.preventDefault() | |||
| if (!$(event.target).is('input')) { | |||
There was a problem hiding this comment.
You probably want this test instead /input|textarea/i.test(event.target.tagName).
It include the case of both textarea and input plus it avoid doing a JQuery dom selection.
Also it's more consistent with the code in other plugins
There was a problem hiding this comment.
Yes thank you @vanduynslagerp ! That's the regex I looked for but didn't found it 😄
Johann-S
force-pushed
the
v4-collapse-input
branch
from
36718ad to
111f81b
Compare
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop preventing event for input in Collapse
/CC @mdo and @bardiharborow
Fixes #22049, fixes #21079