Revamp button and input vars while fixing #21587 #22287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
— Updates $btn- and $input- variables for padding and line-height to be shared like the $input-btn-border-width variable. — Moves from 1.333 lg line-height to 1.5 for better and easier math that matches the small inputs and buttons. — Updates button-size mixin to accept a line-height argument Also closes #21592
houndci-bot
reviewed
Mar 28, 2017
scss/_input-group.scss
Outdated
| font-size: $font-size-sm; | ||
| @include border-radius($input-border-radius-sm); | ||
| } | ||
|
|
This was referenced Mar 28, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates a handful of button and input variables. Originally it started as a fix for #21587 that I was testing from #21592, but it moved this direction as I read the thread and stared at the code trying to ensure the large inputs matched the same code as the small ones.
Demo at https://jsbin.com/jufibek/.
$btn-and$input-variables forpaddingandline-heightto be shared like the$input-btn-border-widthvariable.1.333lg line-height to1.5for better and easier math that matches the small inputs and buttons.Also closes #21592.