Fix collapse.js aria-expanded behavior #22397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aria-expanded="true"/aria-expanded="false" only applies to the trigger, not the element that is being expanded/collapsed.
...to make it clearer that the aria-expanded attribute always just goes on the control.
- reword some of the text to make it clear we're checking behavior of trigger/control - move incorrect aria-expanded out of the <div>s and to the actual trigger/control <a>s - fix incorrect test assertion text output false -> true
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops incorrectly adding/toggling aria-expanded on the target, as this attribute only applies to the control/trigger. Also expands accessibility note for collapse.js and tweaks the qunit tests.
Closes #22041