Add dropdown menu accessibility callout and fix <a> example #22461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the question often comes up about why Bootstrap does not do "true" ARIA menus (with their `role="menu"` etc), add an admittedly lengthy note (tl;dr because BS is generic, and ARIA menus are specific and quite limiting). Additionally, fixes up the `<a>` example for dropdown trigger, with the missing `role="button"` and neutering the `href` (which would be useless anyway since BS overrides the link-like nature of the `<a>` so it could never be triggered/followed anyway)
|
originally had @mdo set to review, but i think this is fairly non-controversial (though yes, a tad long). going to merge... |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the question often comes up about why Bootstrap does not do "true"
ARIA menus (with their
role="menu"etc), add an admittedly lengthynote (tl;dr because BS is generic, and ARIA menus are specific and quite
limiting).
Additionally, fixes up the
<a>example for dropdown trigger, with themissing
role="button"and neutering thehref(which would be uselessanyway since BS overrides the link-like nature of the
<a>so it couldnever be triggered/followed anyway)