Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): force .navbar .dropdown-menu positioning #22644

Merged
merged 2 commits into from
May 22, 2017
Merged

fix(css): force .navbar .dropdown-menu positioning #22644

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1170ba5
fix(css): force .navbar .dropdown-menu positioning
zalog May 17, 2017
5cd795e
Merge branch 'v4-dev' into fix-navbar-dropdown
Johann-S May 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions scss/_navbar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@
padding-right: 0;
padding-left: 0;
}

.dropdown-menu {
position: static !important;
float: none;
transform: unset !important;
}
}


Expand Down Expand Up @@ -136,14 +142,6 @@

&#{$infix} {
@include media-breakpoint-down($breakpoint) {
.navbar-nav {
.dropdown-menu {
position: static !important;
float: none;
transform: unset !important;
}
}

> .container,
> .container-fluid {
padding-right: 0;
Expand All @@ -160,7 +158,8 @@
flex-direction: row;

.dropdown-menu {
position: absolute;
position: absolute !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about that because Popper always use absolute position

Copy link
Contributor Author

@zalog zalog May 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I know.
But now, because of mobile first abordation, we need to overwrite L80.

Why mobile first abordation:

  • for navbars that never collapse, .navbar.navbar-expand. My first navbar in the before example
  • for navbars that always collapse, just .navbar class. My third navbar example in that before pen

top: 100% !important;
}

.nav-link {
Expand Down