Use Popper.js to manage arrow position #22681
Conversation
| <div class="popover bs-popover-right"> | ||
| <div class="arrow"></div> | ||
| <div class="popover bs-popover-right bs-popover-right-docs"> | ||
| <div class="arrow" x-arrow></div> |
There was a problem hiding this comment.
Note that you may override the x-arrow selector and simply use .arrow as selector if you prefer.
There was a problem hiding this comment.
Yes, but do you know if it will cause Bootstrap some issues to use x-arrow attribute ? If not I'll keep x-arrow.
But thank you for letting me know that 👍
There was a problem hiding this comment.
IMO this would be preferable since it would decouple Bootstrap from a library to manage positioning. This is especially important for libraries that build on top of Bootstrap's CSS and re-do JavaScript logic (ex.: https://ng-bootstrap.github.io/#/components/popover)
There was a problem hiding this comment.
There aren't problems using x-arrow, but as @pkozlowski-opensource said, you may want to reduce the points of junction between Bootstrap and Popper.js to avoid to coupling them too much.
There was a problem hiding this comment.
Feel free to open a pull request @pkozlowski-opensource if you want to handle that 👍
There was a problem hiding this comment.
Will do. Thnx @Johann-S @FezVrasta
Use Popper.js to manage arrow position instead of using CSS
Close : #22669, #22572