Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ::first-letter and ::first-line selectors from print styles #23044

Merged
merged 2 commits into from
Jul 11, 2017
Merged

Remove ::first-letter and ::first-line selectors from print styles #23044

merged 2 commits into from
Jul 11, 2017

Conversation

patrickhlauke
Copy link
Member

Bootstrap itself doesn't use any ::first-letter or ::first-line
styles. These selectors also cause(d) problems in IE11 (see
h5bp/html5-boilerplate#1799) and currently cause
a nasty rendering bug in Chrome where the first letter is vertically
shifted (see #21771)

Closes #21771

Bootstrap itself doesn't use any `::first-letter` or `::first-line`
styles. These selectors also cause(d) problems in IE11 (see
h5bp/html5-boilerplate#1799) and currently cause
a nasty rendering bug in Chrome where the first letter is vertically
shifted (see #21771)
@patrickhlauke
Copy link
Member Author

patrickhlauke commented Jul 11, 2017

I know this doesn't address the fundamental problem (which is due to a Chrome bug), but rather circumvents it...nonetheless, as it's not really a problem we actually have (since we don't set any ::first-letter / ::first-line text or box shadows), I'd say it's ok to leave that battle to be fought by somebody else / let Chrome fix their bug

As h5bp has now removed these as well, no need to keep and comment them
out. See h5bp/html5-boilerplate#1961 /
h5bp/html5-boilerplate#1962
@patrickhlauke patrickhlauke removed the request for review from mdo July 11, 2017 18:48
@patrickhlauke
Copy link
Member Author

h5bp have now removed those styles as well (after i filed an issue), so i might be bold enough to merge this without bothering @mdo for a review (as it was mainly to know if it was cool to comment those things out/diverge from h5bp)

@patrickhlauke patrickhlauke merged commit 7a781b2 into twbs:v4-dev Jul 11, 2017
@mdo mdo mentioned this pull request Jul 11, 2017
@mdo
Copy link
Member

mdo commented Jul 16, 2017

This issue (and many others) was slated for Beta 2 to limit the remaining changes ahead of Beta 1. It's fine that it merged, but I'm trying to get us to do a better job of organizing bugs and new features into more coherent and regularly shippable releases :).

I've updated the issue this fixed to reflect it's status in the Beta 1 project.

@patrickhlauke
Copy link
Member Author

@mdo oops sorry, missed that we're now using the "projects" thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants