-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #23100: Add xs: 100% in $container-max-widths #23106
Conversation
I think the fix that was provided in the issue you mentioned is a better fix |
so this PR is good, right? no need to change as per his suggestion? |
you added a xs value to the |
@gijsbotje have made change as per suggestion in #23100 sorry for multiple PR |
Digging this change for Beta 1—testing and will merge with some additional changes shortly. Here's a quick recap on why it's helpful:
With this PR, we can remove both those previous fixes for the original navbar issue, thereby fixing all containers in and outside navbars. |
Thanks for merging |
Fix issue mention in #23100, i have added xs: width 100% in _variable.scss file $container-max-widths.