added icon in form validation in #22762 #23312
Conversation
scss/mixins/_forms.scss
Outdated
| &:focus { | ||
| box-shadow: 0 0 0 .2rem rgba($color,.25); | ||
| box-shadow: 0 0 0 0.2rem rgba($color, 0.25); |
There was a problem hiding this comment.
0.2 should be written without a leading zero as .20.25 should be written without a leading zero as .25
scss/mixins/_forms.scss
Outdated
| @@ -56,8 +75,9 @@ | |||
| .was-validated &:#{$state}, | |||
| &.is-#{$state} { | |||
| ~ .custom-control-indicator { | |||
| background-color: rgba($color, .25); | |||
| background-color: rgba($color, 0.25); | |||
There was a problem hiding this comment.
0.25 should be written without a leading zero as .25
scss/mixins/_forms.scss
Outdated
| @@ -40,6 +52,13 @@ | |||
| } | |||
| } | |||
|
|
|||
| // Validation icon top for textarea | |||
| textarea.form-control, | |||
There was a problem hiding this comment.
Avoid qualifying class selectors with an element.
scss/mixins/_forms.scss
Outdated
|
|
||
| &:focus { | ||
| box-shadow: 0 0 0 .2rem rgba($color,.25); | ||
| box-shadow: 0 0 0 0.2rem rgba($color, 0.25); |
There was a problem hiding this comment.
0.2 should be written without a leading zero as .20.25 should be written without a leading zero as .25
scss/mixins/_forms.scss
Outdated
| &:focus { | ||
| box-shadow: 0 0 0 .2rem rgba($color,.25); | ||
| box-shadow: 0 0 0 0.2rem rgba($color, 0.25); |
There was a problem hiding this comment.
0.2 should be written without a leading zero as .20.25 should be written without a leading zero as .25
scss/mixins/_forms.scss
Outdated
| @@ -56,8 +75,9 @@ | |||
| .was-validated &:#{$state}, | |||
| &.is-#{$state} { | |||
| ~ .custom-control-indicator { | |||
| background-color: rgba($color, .25); | |||
| background-color: rgba($color, 0.25); | |||
There was a problem hiding this comment.
0.25 should be written without a leading zero as .25
scss/mixins/_forms.scss
Outdated
| @@ -40,6 +52,13 @@ | |||
| } | |||
| } | |||
|
|
|||
| // Validation icon top for textarea | |||
| textarea.form-control, | |||
There was a problem hiding this comment.
Avoid qualifying class selectors with an element.
There was a problem hiding this comment.
can any one please guide me on this issue?
There was a problem hiding this comment.
Doesn't this work?
element {
&.class {
}
}EDIT: nah, it would still complain.
There was a problem hiding this comment.
There was a problem hiding this comment.
@XhmikosR Thank you!!
scss/mixins/_forms.scss
Outdated
|
|
||
| &:focus { | ||
| box-shadow: 0 0 0 .2rem rgba($color,.25); | ||
| box-shadow: 0 0 0 0.2rem rgba($color, 0.25); |
There was a problem hiding this comment.
0.2 should be written without a leading zero as .20.25 should be written without a leading zero as .25
|
can any one let me know what is the right way for this Avoid qualifying class selectors with an element. validation issue? |
scss/mixins/_forms.scss
Outdated
| @@ -40,6 +52,15 @@ | |||
| } | |||
| } | |||
|
|
|||
| // Validation icon top for textarea | |||
| textarea { | |||
| &.form-control, | |||
scss/mixins/_forms.scss
Outdated
| @@ -40,6 +52,15 @@ | |||
| } | |||
| } | |||
|
|
|||
| // Validation icon top for textarea | |||
| textarea { | |||
| &.form-control, | |||
scss/mixins/_forms.scss
Outdated
| background-image: $form-icon-success; | ||
| } | ||
|
|
||
| @if $state == "invalid" { |
There was a problem hiding this comment.
Yup definitely good suggestion @vsn4ik
scss/mixins/_forms.scss
Outdated
| background-image: $form-icon-success; | ||
| } | ||
|
|
||
| @else if $state == "invalid" { |
There was a problem hiding this comment.
@else should be placed on same line as previous curly brace
|
@mdo: what do we do with this? I think we better drop this from a quick look... |
|
New PR at #26824. |
added form validation icon mention in #22762