Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .btn-outline-light hover color #23403

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Fix .btn-outline-light hover color #23403

merged 1 commit into from
Aug 15, 2017

Conversation

mdo
Copy link
Member

@mdo mdo commented Aug 14, 2017

Uses some if/else action to ensure there's readable text on hover. Swapped out a hex value to a variable while I was in there.

Fixes #23398, fixes #23351.

Uses some if/else action to ensure there's readable text on hover. Swapped out a hex value to a variable while I was in there.

Fixes #23398, fixes #23351.
@XhmikosR
Copy link
Member

Text looks unreadable being white now :/

@mdo
Copy link
Member Author

mdo commented Aug 14, 2017

@XhmikosR Are you commenting on the changes in this branch, or what's currently in v4-dev?

@XhmikosR
Copy link
Member

@mdo: on the changes in this branch. v4-dev has black for text. :)

@mdo
Copy link
Member Author

mdo commented Aug 15, 2017

@XhmikosR See #23351. On hover it's illegible on the hosted docs, but it's fine with this:

screen shot 2017-08-14 at 8 57 22 pm

screen shot 2017-08-14 at 8 57 27 pm

@mdo mdo merged commit 5b8738a into v4-dev Aug 15, 2017
@mdo mdo mentioned this pull request Aug 15, 2017
@mdo mdo deleted the outline-light-btn-text branch December 30, 2017 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants