Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Viewport Height & Width helpers #25548

Merged
merged 3 commits into from
Oct 23, 2018
Merged

Added Viewport Height & Width helpers #25548

merged 3 commits into from
Oct 23, 2018

Conversation

ItaloBC
Copy link
Contributor

@ItaloBC ItaloBC commented Feb 4, 2018

This allows the user to make a container (ideally) to use viewport height and width and allow better vertical/horizontal alignments of elements.

This allows the user to make a container (ideally) to use viewport height and width and allow better vertical/horizontal alignments of elements.
@XhmikosR XhmikosR requested a review from mdo February 5, 2018 05:33
@mdo mdo added the feature label Feb 6, 2018
@mdo
Copy link
Member

mdo commented Oct 21, 2018

I previously punted on these being responsive, but these are good to go. Just want to call that out and explicitly support this direction over that one.

@mdo mdo mentioned this pull request Oct 23, 2018
@XhmikosR XhmikosR merged commit 557f3fe into twbs:v4-dev Oct 23, 2018
@guledali
Copy link

guledali commented Oct 25, 2018

@mdo @XhmikosR I'm curious why this pull-request over #27397

Don't get me wrong I'm glad that you guys finally adding view-port utility, it just not enough I want variation on the sizing.

@XhmikosR
Copy link
Member

@guledali:

I previously punted on these being responsive, but these are good to go. Just want to call that out and explicitly support this direction over that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants