Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#25842 Remove max-width from table class #25864

Merged
merged 1 commit into from
Jul 15, 2018

Conversation

bakedbird
Copy link

@bakedbird bakedbird commented Mar 15, 2018

max-width: 100% was causing issues on
macOs safari
iOs safari

Removed max-width and tested for possible side-effects on:
os: macOs
browsers: Safari, Chrome, Opera, Firefox

and iPhoneX safari (on browserStack)

Fixes #25842

@XhmikosR XhmikosR requested a review from mdo March 17, 2018 00:07
@mdo
Copy link
Member

mdo commented Mar 17, 2018

Without a demo reproducing these problems you mention, we cannot accept the PR.

@mdo mdo closed this Mar 17, 2018
@bakedbird
Copy link
Author

@mdo what do you mean? The PR was the fix for #25842

@andresgalante
Copy link
Collaborator

@mdo I'll reopen this one since there is an example in this issue #25842

I haven't review the PR yet.

@andresgalante andresgalante reopened this Apr 6, 2018
@aledbrown
Copy link

I can confirm this bug happens on iOS Safari with class="table table-dark" and a responsive table div surrounding the table. The dark table only renders to the initial view box. Scroll the table horizontally and the background goes white again.

The fix also seems to work fine. So I've done this to fix it for now on the specific table I'm having the issue with:

<div class="table-responsive-xl">
<table style="max-width: none !important;" class="table table-dark table-striped table-hover table-bordered">
...

@mdo mdo merged commit 9bfd400 into twbs:v4-dev Jul 15, 2018
@mdo mdo mentioned this pull request Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants