Fix xss in tooltip, collapse and scrollspy plugins #26630
Merged
+50
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, it seems we are having some test failures @Johann-S :/ BTW, do we have any other places like these? Would be ideal if we tackled all similar issues now and release a new patch release soon-ish. |
|
yep I'm on it 😉 just a few minutes It's a bit hard to identify all the possible XSS in once 😟 we should check all of our options |
|
@Johann-S: let's get this merged and hopefully people will report if there are any other cases. |
XhmikosR
approved these changes
Jun 1, 2018
Closed
This was referenced Oct 23, 2019
Open
Open
Closed
This was referenced Oct 30, 2019
This was referenced Aug 9, 2022
This was referenced Feb 26, 2023
This was referenced Mar 31, 2023
This was referenced Apr 26, 2023
This was referenced Jul 10, 2023
This was referenced Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26625 / CVE-2018-14040
Fixes #26627 / CVE-2018-14041
Fixes #26628 / CVE-2018-14042
/CC @XhmikosR and @1Jesper1