Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes modal positioning on android (#26760) #26811

Closed
wants to merge 0 commits into from
Closed

Conversation

jvitela
Copy link
Contributor

@jvitela jvitela commented Jul 6, 2018

When address bar is hidden, sometimes the visual position of the controls is out of sync with its logical position.

@jvitela
Copy link
Contributor Author

jvitela commented Oct 8, 2018

@MartijnCuppens, @mdo Can somebody review this changes? They've been sitting here for a while :-(

@mdo
Copy link
Member

mdo commented Oct 21, 2018

I don't have an Android on me at this time to test unfortunately. Anyone else?

@XhmikosR
Copy link
Member

@mdo: You can use Browser Stack.

@MartijnCuppens: can you review please?

@MartijnCuppens
Copy link
Member

@jvitela, can you also add this fix for .modal-backdrop?

@MartijnCuppens
Copy link
Member

This is better, but now I see the backdrop isn't stretching at the bottom when address bar is hidden. Can you check if you can fix this @jvitela?

@jvitela
Copy link
Contributor Author

jvitela commented Nov 2, 2018

Using viewport units for sizing .modal-backdrop solves the resizing issues and also eliminates the undesired effect of the modal jumping up and down after the address bar appears/disappears.

@mdo
Copy link
Member

mdo commented Nov 3, 2018

@MartijnCuppens If you confirmed latest changes fix your issues, this looks good to me. I don't have an Android phone right now to test myself.

@MartijnCuppens
Copy link
Member

MartijnCuppens commented Nov 3, 2018

Nope, height: 100vh will make the modal scrollable if the address bar is shown. I'll check tomorrow if there's something we can do about this.

Edit:
That's normal behaviour, it needs to be scrollable so that it's possible to show the address bar when it's hidden

@MartijnCuppens
Copy link
Member

Something went wrong here, we're looking into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants