-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes modal positioning on android (#26760) #26811
Conversation
@MartijnCuppens, @mdo Can somebody review this changes? They've been sitting here for a while :-( |
I don't have an Android on me at this time to test unfortunately. Anyone else? |
@mdo: You can use Browser Stack. @MartijnCuppens: can you review please? |
@jvitela, can you also add this fix for |
This is better, but now I see the backdrop isn't stretching at the bottom when address bar is hidden. Can you check if you can fix this @jvitela? |
Using viewport units for sizing |
@MartijnCuppens If you confirmed latest changes fix your issues, this looks good to me. I don't have an Android phone right now to test myself. |
Nope, Edit: |
704584a
to
eeea8b5
Compare
Something went wrong here, we're looking into it |
When address bar is hidden, sometimes the visual position of the controls is out of sync with its logical position.