Simpler carousel indicators css #26996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I definitely like this, but better wait for one more approval. |
|
Ping @andresgalante @mdo |
mdo
reviewed
Aug 19, 2018
scss/_carousel.scss
Outdated
| margin-right: $carousel-indicator-spacer; | ||
| margin-left: $carousel-indicator-spacer; | ||
| text-indent: -999px; | ||
| cursor: pointer; | ||
| background-color: $carousel-indicator-active-bg; | ||
| background-clip: padding-box; | ||
| // Use transparent borders to increase the hit area by 10px on top and bottom. | ||
| border-top: 10px solid transparent; |
There was a problem hiding this comment.
Can we move to a variable for the 10px value, and then use that here, on L196 and L187?
There was a problem hiding this comment.
Changed it to a variable and used box-sizing: content-box instead of adding the hit area height to indicator height (this makes it possible to define the hit area height in another unit).
XhmikosR
approved these changes
Aug 26, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pseudo elements are used to increase the hit area by 10px on top and bottom, but this can also be done with transparent borders which saves a bit css.
Demo: https://codepen.io/MartijnCuppens/pen/ajNXZj