Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move media from layout to components #27206

Merged
merged 3 commits into from
Oct 17, 2018
Merged

Conversation

MartijnCuppens
Copy link
Member

As suggested by @ysds, move the media page from layout to components

  • Moved page in menu structure
  • Moved media-object.md file to components folder
  • Also searched for occurrences of media-object page in links in the docs (but there is also a test for 404 links which covers this, I just realised this while I'm writing this 🙂)

Closes #27165

@XhmikosR
Copy link
Member

Just a note, if we are going with this, we need to add a redirect too.

@MartijnCuppens
Copy link
Member Author

@XhmikosR, I was also thinking about this, but if this is going to be changed in 4.2 and not in 4.1, it won't be necessary since we only add urls and not change them?

@XhmikosR
Copy link
Member

True, but this is a fairly new scheme. And I'd rather err on the non-broken pages around the web :)

So, if this is going to be merged in a new minor version, I guess we don't need the redirect.

@XhmikosR
Copy link
Member

@mdo: are you OK with this?

@mdo
Copy link
Member

mdo commented Sep 18, 2018

Eh, I'm not strongly attached to one direction over the other. For context, I don't see .media sticking around in v5 anyway, so it's dead to me either way lol. Y'all decide :).

@XhmikosR XhmikosR merged commit 832a90d into twbs:v4-dev Oct 17, 2018
@mdo mdo mentioned this pull request Oct 17, 2018
@MartijnCuppens MartijnCuppens deleted the move-media branch October 17, 2018 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants