Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use the bundle dist file. #27228

Merged
merged 2 commits into from
Sep 18, 2018
Merged

docs: use the bundle dist file. #27228

merged 2 commits into from
Sep 18, 2018

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Sep 14, 2018

This is WIP because we probably need to go through the docs and make sure we list/suggest the bundle everywhere

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-docs-js-bundle branch from eff60ef to 39dc1a8 Compare September 15, 2018 12:18
@Johann-S
Copy link
Member

IMO we did it to talk about our bundle file everywhere in our docs 🤔

@XhmikosR XhmikosR changed the title [WIP] docs: use the bundle dist file. docs: use the bundle dist file. Sep 17, 2018
@XhmikosR
Copy link
Member Author

Let's wait for one more approval then. :)

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this. No strong feelings one way or another.

site/_includes/scripts.html Show resolved Hide resolved
@XhmikosR XhmikosR merged commit 787441d into v4-dev Sep 18, 2018
@XhmikosR XhmikosR deleted the v4-dev-xmr-docs-js-bundle branch September 18, 2018 09:50
@mdo mdo mentioned this pull request Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants