-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 'show' and 'hide' methods to dropdown #27370
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8749a4c
Added 'show' and 'hide' methods to dropdown
galczo5 c38d152
Added unit tests for dropdown.js 'show' and 'hide' methods
galczo5 174da9d
Added more tests of show/hide methods in dropdown.js
galczo5 78a8af1
Refactored isActive in dropdown.js
galczo5 4de4f2e
Merge branch 'v4-dev' into dropdown-show-hide
Johann-S b2a75f6
Added description of show/hide methods in dropdowns.md
galczo5 aceef81
Merge branch 'dropdown-show-hide' of https://github.com/galczo5/boots…
galczo5 dc37f7c
Merge branch 'v4-dev' into dropdown-show-hide
XhmikosR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -194,6 +194,61 @@ class Dropdown { | |
.trigger($.Event(Event.SHOWN, relatedTarget)) | ||
} | ||
|
||
show() { | ||
if (this._element.disabled || $(this._element).hasClass(ClassName.DISABLED)) { | ||
return | ||
} | ||
const isActive = $(this._menu).hasClass(ClassName.SHOW) | ||
if (isActive) { | ||
return | ||
} | ||
|
||
const relatedTarget = { | ||
relatedTarget: this._element | ||
} | ||
const showEvent = $.Event(Event.SHOW, relatedTarget) | ||
|
||
const parent = Dropdown._getParentFromElement(this._element) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. trailing spaces |
||
$(parent).trigger(showEvent) | ||
|
||
if (showEvent.isDefaultPrevented()) { | ||
return | ||
} | ||
|
||
$(this._menu).toggleClass(ClassName.SHOW) | ||
$(parent) | ||
.toggleClass(ClassName.SHOW) | ||
.trigger($.Event(Event.SHOWN, relatedTarget)) | ||
} | ||
|
||
hide() { | ||
if (this._element.disabled || $(this._element).hasClass(ClassName.DISABLED)) { | ||
return | ||
} | ||
|
||
const isActive = $(this._menu).hasClass(ClassName.SHOW) | ||
if (!isActive) { | ||
return | ||
} | ||
|
||
const relatedTarget = { | ||
relatedTarget: this._element | ||
} | ||
const hideEvent = $.Event(Event.HIDE, relatedTarget) | ||
|
||
const parent = Dropdown._getParentFromElement(this._element) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. trailing spaces |
||
$(parent).trigger(hideEvent) | ||
|
||
if (hideEvent.isDefaultPrevented()) { | ||
return | ||
} | ||
|
||
$(this._menu).toggleClass(ClassName.SHOW) | ||
$(parent) | ||
.toggleClass(ClassName.SHOW) | ||
.trigger($.Event(Event.HIDDEN, relatedTarget)) | ||
} | ||
|
||
dispose() { | ||
$.removeData(this._element, DATA_KEY) | ||
$(this._element).off(EVENT_KEY) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe skip
isActive
here and later one since they are used only once.